Changed mnist map size, paths, file extensions#4003
Closed
joelself wants to merge 2 commits intoBVLC:windowsfrom
Closed
Changed mnist map size, paths, file extensions#4003joelself wants to merge 2 commits intoBVLC:windowsfrom
joelself wants to merge 2 commits intoBVLC:windowsfrom
Conversation
…les to exe instead of bin. Changed the paths of executables to match their output directories when built with visual studio, but only for Release.
Contributor
Looks fine except the lint error? Could you change tabs to spaces and update please? |
Author
|
Sorry about that. I couldn't get NuGet to work properly and the only way to get it working was to completely reinstall Windows and VS and I hadn't yet turned on visible spaces/tabs. I also fixed the comment that said "1 TB" to say "75 MB" instead. |
Contributor
|
Looks great. Could you squash into a single commit please? |
Contributor
Can we please merge #3731 instead of this temporary fix? |
Member
|
#3731 does look to be a more general solution. |
Author
|
I agree #3731 is a more comprehensive solution. Feel free to close this. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the mnist example
convert_mnist_data.cppcreates a 1 TB lmdb which fails if you don't have a terabyte to spare on your drive. I reduced it to 75 MB.The scripts also assume that that executables will end with
binwhen on Windows they end withexeso I changed those too.The location of binaries is different on Windows as well. I changed the path of the mnist examples to use the Windows path (the Release path, still won't work for Debug builds).