Skip to content

Write/create/truncate prototxt when saving to fix #341#417

Merged
jeffdonahue merged 2 commits intoBVLC:devfrom
shelhamer:create-and-write-proto
May 14, 2014
Merged

Write/create/truncate prototxt when saving to fix #341#417
jeffdonahue merged 2 commits intoBVLC:devfrom
shelhamer:create-and-write-proto

Conversation

@shelhamer
Copy link
Member

Create the output file if it doesn't exist or overwrite it if it exists with content when saving a prototxt and set permissions to owner all and group + other read.

One could overwrite a prototxt this way, but such is the peril of saving files.

This will cherry-picked to master or a new release will be made soon enough to fix the problem there.

shelhamer added 2 commits May 14, 2014 12:28
WriteProtoToTextFile now saves the prototxt whether or not the file
already exists and sets the permissions to owner read/write and group +
other read.

Thanks @beam2d and @chyh1990 for pointing out the open modes bug.
@jeffdonahue
Copy link
Contributor

Cool, thanks Evan!

jeffdonahue added a commit that referenced this pull request May 14, 2014
Write/create/truncate prototxt when saving to fix #341
@jeffdonahue jeffdonahue merged commit 91c59d7 into BVLC:dev May 14, 2014
@shelhamer shelhamer deleted the create-and-write-proto branch May 15, 2014 06:55
mitmul pushed a commit to mitmul/caffe that referenced this pull request Sep 30, 2014
Write/create/truncate prototxt when saving to fix BVLC#341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments