Conversation
shelhamer
added a commit
that referenced
this pull request
May 27, 2014
Make net preprocessing options belong to instantiated net and not class
Member
Author
|
Fixed in master @ 1bb7ba5. |
sguada
pushed a commit
to sguada/caffe-public
that referenced
this pull request
May 27, 2014
…embers Make net preprocessing options belong to instantiated net and not class
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
…embers Make net preprocessing options belong to instantiated net and not class
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
…embers Make net preprocessing options belong to instantiated net and not class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preprocessing members
mean,input_scale, andchannel_swapwere accidentally scoped as class members, making all instantiated caffe.Nets share the same input preprocessing options. This dodges the python boost constructor by doing an initialization check on the setters. It's a fix for now-truth and beauty can come later.