Skip to content

Comments

Bilinear filler value corrected when matrix size is odd.#4677

Closed
zhengwy888 wants to merge 1 commit intoBVLC:masterfrom
zhengwy888:feature
Closed

Bilinear filler value corrected when matrix size is odd.#4677
zhengwy888 wants to merge 1 commit intoBVLC:masterfrom
zhengwy888:feature

Conversation

@zhengwy888
Copy link

I believe there was an typo in BilinearFiller.
E.g. if you set the kernel size to be 3. the filler produces the following result:

0.062500 0.187500 0.187500 
0.187500 0.562500 0.562500 
0.187500 0.562500 0.562500

Where it should have been

0.250000 0.500000 0.250000 
0.500000 1.000000 0.500000 
0.250000 0.500000 0.250000 

Looking at the code and this is because the matrix size condition (f%2) should have used the actual matrix size.

Let me know what you think.

@Noiredd Noiredd mentioned this pull request Jun 27, 2017
3 tasks
@Noiredd
Copy link
Member

Noiredd commented Feb 5, 2018

Fixed in #5713.

@Noiredd Noiredd closed this Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants