Skip to content

Benchmarking should not impact perf until timer is read#4702

Merged
shelhamer merged 1 commit intoBVLC:masterfrom
cypof:timer_sync_on_read
Sep 9, 2016
Merged

Benchmarking should not impact perf until timer is read#4702
shelhamer merged 1 commit intoBVLC:masterfrom
cypof:timer_sync_on_read

Conversation

@cypof
Copy link
Copy Markdown
Member

@cypof cypof commented Sep 9, 2016

For timing operations in a net, it should be possible to add events to a GPU stream without synchronizing, to have a lower impact on performance and more accuracy. Synchronizing is only required when reading the timer, e.g. once at the end of an iteration instead of at each layer.

@shelhamer
Copy link
Copy Markdown
Member

Looks good to me. Thanks Cyprien!

@shelhamer shelhamer merged commit 048530a into BVLC:master Sep 9, 2016
@shelhamer
Copy link
Copy Markdown
Member

shelhamer commented Sep 9, 2016

@flx42 could you comment on whether this resolves #4453? I see that you took another approach there with two passes, but is that necessary/is the overhead that significant?

@ujsyehao
Copy link
Copy Markdown

@shelhamer It is a big overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants