CPU only tests#478
Conversation
There was a problem hiding this comment.
Could you return this to the original one-line format?
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces
|
Looks good to me, thanks for cleaning the CPU and GPU test :) |
src/caffe/common.cpp
Outdated
There was a problem hiding this comment.
Since we tend to stick to the Google style guide, kindly rename this to
static bool g_curand_availability_logged = false;
and likewise below.
|
Both issues have been fixed. Ready to be merged. |
|
@shelhamer Once the coldbrew master agrees, let's merge :) |
src/caffe/test/test_syncedmem.cpp
Outdated
There was a problem hiding this comment.
Why was this test dropped? the recovered_value test that follows is the one actually checking the sync, and the memset should always succeed, but tests are tests.
|
@shelhamer, the memtest issue is resolved. Please review again. Thanks! |
|
Thanks @kloudkl! |
CPU only tests
To enable running the tests on machines with only the CPU, the GPU related codes have to be separated.
Related issue: #468