Make sure memory is allocated to only one device, enforce if debug#4792
Closed
cypof wants to merge 1 commit intoBVLC:masterfrom
Closed
Make sure memory is allocated to only one device, enforce if debug#4792cypof wants to merge 1 commit intoBVLC:masterfrom
cypof wants to merge 1 commit intoBVLC:masterfrom
Conversation
Member
Author
|
In the nccl branch, WorkerSolver goes away so it makes this simpler too. |
Member
|
Closed as handled by #4563 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added checks while debugging the new multi-GPU code. It's simpler to always enforce a single device instead of trying to switch on the fly. If we merge that I can rebase the nccl branch on it.