Conversation
Member
There was a problem hiding this comment.
Is this change intended? I guess it is fine to initialize a RNG and not use it, but this modification seems unnecessary...
Contributor
Author
There was a problem hiding this comment.
Yes, it is. The change fixes the segementation fault caused by uninitialized prefetch_rng_. This is indeed a bug considering where prefetch_rng_ is used in the prefetch thread. Perhaps it was not caught earlier because the ImageDataLayer parameter combinations did not run through the specific code path.
The DataLayer and the WindowDataLayer are both correct in this respect.
Member
|
Thanks for the update, merging... |
Yangqing
added a commit
that referenced
this pull request
Jun 23, 2014
Image data layer rng core dump
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Image data layer rng core dump
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The back trace of the core dump file shows that the error occurs in
caffe::ImageDataLayer<float>::PrefetchRand. The root cause is thatprefetch_rng_is not initialized properly inCreatePrefetchThread. Luckily, there is no such bug in the DataLayer and the WindowDataLayer.