Conversation
With associated Makefile changes for .cu tests This tests that the grid-stride loop works for im2col, using the CPU version as a reference.
Member
|
Please take another look at the Makefile as this seems to break the parallel build: Thanks for the test! |
Member
|
Other than that this looks good to me. @Yangqing please take a look to double-check. |
The changes for .cu tests meant that creating TEST_BUILD_DIR wasn't happening first
Contributor
Author
|
This should fix the make error (although I'm not sure it's the best way). |
Member
|
Merging, as I have further Makefile changes to make and this is good. Thanks @jamt9000! |
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Test for im2col kernel
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
Test for im2col kernel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test for #427
With associated Makefile changes for .cu tests