Layers in order#602
Merged
jeffdonahue merged 3 commits intoBVLC:devfrom Jul 4, 2014
kloudkl:layers-in-order
Merged
Conversation
Member
|
This looks neatly arranged to me. @jeffdonahue please take a look and merge if you like this organization. |
Contributor
|
Looks good to me. I think InnerProductLayer and EltwiseLayer could also be moved to common_layers -- generally I'd say any layer that doesn't care about the height/width structure of the input seems like it shouldn't be specifically called a "vision layer". |
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Layers in order
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
Layers in order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reponse to @shelhamer's advice, ArgmaxLayer, ConcatLayer, FlattenLayer, SoftmaxLayer and SplitLayer are moved into common_layers. ConvolutionLayer, EltwiseLayer, Im2colLayer, InnerProductLayer, LRNLayer and PoolingLayer stay in the vision_layers. But your mileage may vary.
The data layers and the loss layers are in alphabetical order with the exception that the LossLayer is above its subclasses.