Put the acc_data in a new syncedmemory block#6141
Closed
sonack wants to merge 2 commits intoBVLC:masterfrom
Closed
Put the acc_data in a new syncedmemory block#6141sonack wants to merge 2 commits intoBVLC:masterfrom
sonack wants to merge 2 commits intoBVLC:masterfrom
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was using Accuracy Layer in Training Phase, I found something weird, the loss was increasing and the gradient was much larger than normal.
A easy reproduction example is to uncomment the
include_phaseof accuracy layer incaffe/examples/cifar10/cifar10_quick_train_test.prototxtand usetrain_quick.shto train it.After strugglely reviewing the source code, I found this line in
accuracy_layer.cuis the cause for it, it was sayingSince this memory is not used for anything,we use it here to avoid having to allocate new GPU memory to accumulate intermediate results in the kernel.But it is wrong, because when I use some blob in both loss layer and accuracy layer, caffe would insert split layer to duplicate this blob, and during the backward pass, the splited blob for accuracy layer 's diff would not be updated(covered) and should always be zero. However, here changed its value to the accuracy, which made the gradient after split layer is much larger.
I modified this line to allocate a new syncedmem object to store the acc_data, which made it independent with the bottom[0]'s diff field and solved above issue.