PoolingLayer customizable output shape rounding mode#6282
Merged
Noiredd merged 1 commit intoBVLC:masterfrom Aug 17, 2018
Merged
PoolingLayer customizable output shape rounding mode#6282Noiredd merged 1 commit intoBVLC:masterfrom
Noiredd merged 1 commit intoBVLC:masterfrom
Conversation
Member
|
+1 for merging this! |
Member
Author
|
Sorry for a long delay, I've been tied up with work. I'll try to catch up with PRs and issues in the following days. |
XinYao1994
pushed a commit
to XinYao1994/caffe
that referenced
this pull request
Aug 29, 2018
PoolingLayer customizable output shape rounding mode
beniz
pushed a commit
to jolibrain/caffe
that referenced
this pull request
Sep 24, 2018
PoolingLayer customizable output shape rounding mode
keerthanss
added a commit
to keerthanss/DenseNet-Caffe
that referenced
this pull request
Feb 27, 2019
ceil_mode was proposed in BVLC/caffe#3057 , but never merged. Its replacement, BVLC/caffe#6282 , fulfils the same need with some syntactic variance. The param is now called "round_mode" and it is an enum, instead of a boolean. This commit modifies the files accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resurrection of #3057 which allowed the user to choose how is the pooling output shape calculated, as there is confusion between how does the PoolingLayer do it and how does ConvolutionLayer (see @jeffdonahue's note on this).
This implementation incorporates @seanbell's idea to have the rounding mode as an enum.
Fixes #1318
Closes #3057