"make warn" to print compilation warnings; "make lint" runs incrementally#649
Merged
"make warn" to print compilation warnings; "make lint" runs incrementally#649
Conversation
Member
|
Sweet, thanks Jeff. |
shelhamer
added a commit
that referenced
this pull request
Jul 9, 2014
"make warn" to print compilation warnings; "make lint" runs incrementally
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
"make warn" to print compilation warnings; "make lint" runs incrementally
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
"make warn" to print compilation warnings; "make lint" runs incrementally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #588, allowing you to do
make warnto see all the compiler warnings printed during compilation of C files (really anything that your compiler sent to STDERR, which with gcc is nothing unless you have compiler warnings or errors). It's implemented by sending all STDERR output to another file ending withwarnings.txt(still printing these warnings immediately after compilation even if you never runmake warn) and then concatenating all these warning files into a single summary file afterwards. If your code successfully compiles without any warnings (i.e. the warning summary file is empty) you should see make happily printmake: Nothing to be done 'warn'whenmake warnis run again; otherwise the warnings will be printed every timemake warnis run (but without recompiling).In the second commit, I made lint behave in a similar way, producing a per-file lint report and then concatenating the outputs into a summary lint report. This way lint runs very fast if you run "make lint", change just one source file, and then run "make lint" again -- this is because it's only invoked for the changed file rather than again for the entire codebase.