Consume canvas polyfill to enable text support#251
Merged
rgerd merged 16 commits intoBabylonJS:masterfrom Jun 29, 2021
Merged
Conversation
added 7 commits
June 16, 2021 09:08
chrisfromwork
requested review from
Alex-MSFT,
CedricGuillemet,
bghgary,
rgerd,
rickfromwork,
ryantrem,
syntheticmagus and
tymlipari
chrisfromwork
commented
Jun 22, 2021
| React-jsiexecutor: 124e8f99992490d0d13e0649d950d3e1aae06fe9 | ||
| React-jsinspector: 500a59626037be5b3b3d89c5151bc3baa9abf1a9 | ||
| react-native-babylon: 67b39de846123d0846b28ce0e38671c7e3c4e04f | ||
| react-native-babylon: 858ff09e82f9c3de4f17d66e90d6ca08dd480bb4 |
Contributor
Author
There was a problem hiding this comment.
@ryantrem is there more context around what this guid should map to?
Member
There was a problem hiding this comment.
I think it is a hash. I just ran pod install in the iOS directory. I'm not totally sure how the hash is generated for local packages.
ryantrem
approved these changes
Jun 22, 2021
Member
ryantrem
left a comment
ryantrem
left a comment
There was a problem hiding this comment.
Playground was updated to BJS 28, but the rest of the refs are still at 27. Will you please fix those up before merging?
rgerd
approved these changes
Jun 29, 2021
bghgary
approved these changes
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This review contains the following changes:
Note: we should wait and consume the following change in the babylonnative submodule update BabylonJS/BabylonNative#805
We may also want to wait to update babylon.js dependencies to pick up the following change BabylonJS/Babylon.js#10518 otherwise text still will not work