Skip to content

SWI-8402 Add New StartStream Attributes #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckoegel merged 1 commit into from
Aug 11, 2025
Merged

SWI-8402 Add New StartStream Attributes #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions models/bxml/verbs/StartStream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ export interface StartStreamAttributes {
mode?: string;
tracks?: string;
destination?: string;
destinationUsername?: string;
destinationPassword?: string;
streamEventUrl?: string;
streamEventMethod?: string;
username?: string;
Expand Down
12 changes: 7 additions & 5 deletions tests/unit/models/bxml/verbs/StartStream.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ describe('StartStream', () => {
mode: 'unidirectional',
tracks: 'inbound',
destination: 'https://initial.com',
destinationUsername: 'initialDestUsername',
destinationPassword: 'initialDestPassword',
streamEventUrl: 'https://initial.com',
streamEventMethod: 'POST',
username: 'initialUsername',
Expand All @@ -19,7 +21,7 @@ describe('StartStream', () => {

test('should create a StartStream Verb', () => {
const startStream = new StartStream(attributes);
const expected = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"/>';
const expected = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" destinationUsername="initialDestUsername" destinationPassword="initialDestPassword" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"/>';

expect(startStream).toBeInstanceOf(StartStream);
expect(startStream).toBeInstanceOf(Verb);
Expand All @@ -28,9 +30,9 @@ describe('StartStream', () => {

test('should create a StartStream Verb with nested StreamParams', () => {
let startStream = new StartStream(attributes, streamParam1);
const expected = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/></StartStream>';
const expectedSingle = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/></StartStream>';
const expectedMultiple = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/></StartStream>';
const expected = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" destinationUsername="initialDestUsername" destinationPassword="initialDestPassword" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/></StartStream>';
const expectedSingle = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" destinationUsername="initialDestUsername" destinationPassword="initialDestPassword" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/></StartStream>';
const expectedMultiple = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" destinationUsername="initialDestUsername" destinationPassword="initialDestPassword" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/></StartStream>';

expect(startStream).toBeInstanceOf(StartStream);
expect(startStream).toBeInstanceOf(Verb);
Expand All @@ -45,7 +47,7 @@ describe('StartStream', () => {

test('should test the addStreamParams method when no verbs are initially nested', () => {
const startStream = new StartStream(attributes);
const expected = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/></StartStream>';
const expected = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" destinationUsername="initialDestUsername" destinationPassword="initialDestPassword" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/></StartStream>';

startStream.addStreamParams(streamParam1);
expect(startStream.toBxml()).toBe(expected);
Expand Down