Skip to content
This repository was archived by the owner on Sep 4, 2020. It is now read-only.

Conversation

@zacklitzsinger
Copy link
Contributor

PR Checklist

Check these before submitting your pull request:

  • Visual and behavioral components are separated
  • Exported components are documented with examples
  • Props have JSDoc comments
  • All relevant visual sub-components can be overridden via props
  • Any extra props are spread into the outermost rendered element

Changes to Existing Components

  • Autocomplete is automatically disabled for all Select components. I can't think of a reason that Select should ever have autocomplete.

@zacklitzsinger zacklitzsinger requested a review from a-type August 8, 2019 18:16
@zacklitzsinger zacklitzsinger self-assigned this Aug 8, 2019
@zacklitzsinger zacklitzsinger merged commit fa220cd into master Aug 9, 2019
@zacklitzsinger zacklitzsinger deleted the select-autocomplete branch August 9, 2019 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants