Skip to content
This repository was archived by the owner on Sep 4, 2020. It is now read-only.

fixed some performance problems #311

Merged
zacklitzsinger merged 3 commits into from
Oct 3, 2019
Merged

fixed some performance problems #311

zacklitzsinger merged 3 commits into from
Oct 3, 2019

Conversation

@zacklitzsinger
Copy link
Contributor

@zacklitzsinger zacklitzsinger commented Oct 3, 2019

  • Bumped minimal react-dom version
  • Simplify collision detection logic
  • Debounce the collision detection (this is the major performance improvement here)
  • Only setState if something changed

@zacklitzsinger zacklitzsinger self-assigned this Oct 3, 2019
@zacklitzsinger zacklitzsinger merged commit 7f90c2d into master Oct 3, 2019
@zacklitzsinger zacklitzsinger deleted the dragbox-perf branch October 3, 2019 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tbowen-bw tbowen-bw Awaiting requested review from tbowen-bw

@denysYefremov denysYefremov Awaiting requested review from denysYefremov

3 more reviewers

@SmithPR SmithPR SmithPR approved these changes

@gforrest-bw gforrest-bw gforrest-bw approved these changes

@mzarandona-bw mzarandona-bw mzarandona-bw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zacklitzsinger zacklitzsinger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zacklitzsinger @SmithPR @gforrest-bw @mzarandona-bw