Get TransitClient from VaultClient
#469
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| payload: CertificateRequest | ||
| ): F[VaultSecret[CertificateData]] | ||
|
|
||
| def transitFor(keyName: transit.KeyName): F[transit.VaultTransitClient[F]] |
Contributor
There was a problem hiding this comment.
A way that you may be able to implement this and preserve bincompat is adding something like this:
private [vault] def loginToken: F[String] = applicative.pure("")This way the token is only exposed privately, and it has a default implementation that should satisfy bincompat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use the
Transit/TransitClientmethods we currently need a token, whichVaultClientdoesn't expose. This forces the usage of the deprecatedVaultmethods when vault transit functionality is needed.If we can create a
TransitClientfromVaultClientthe token can be passed under the hood.Unfortunately this breaks binary compatibility, not sure if we can solve this without breaking compatibility.