Skip to content

eng-9466 fix cobadge tests #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jleon15 wants to merge 3 commits into from
Closed

eng-9466 fix cobadge tests #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efd0b47
fix: updating cartes bancaires brand to fix tests
jleon15 Dec 10, 2025
4991735
updating deprecated runner
jleon15 Dec 10, 2025
eed8cb3
fix test
jleon15 Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
run: ./gradlew testDebugUnitTest

acceptance:
runs-on: macos-13
runs-on: macos-15-intel
environment: PR

env:
Expand Down
2 changes: 1 addition & 1 deletion example/src/androidTest/java/com/basistheory/elements/example/CollectCardTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ class CollectCardTests {
.perform(waitUntilVisible(10000L))

onView(withId(R.id.card_brand_selector)).perform(click())
onView(withText("CARTES BANCAIRES")).perform(click())
onView(withText("CARTES_BANCAIRES")).perform(click())

onView(withId(R.id.tokenize_button)).check(matches(isEnabled()))
}
Expand Down
2 changes: 1 addition & 1 deletion lib/src/main/java/com/basistheory/elements/constants/CardBrands.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ enum class CardBrands(val label: String) {
MIR("mir"),
HIPER("hiper"),
HIPERCARD("hipercard"),
CARTES_BANCAIRES("cartes-bancaires")
Copy link
Contributor

@ddiestra ddiestra Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should remain as it is

CARTES_BANCAIRES("cartes_bancaires")
}
2 changes: 1 addition & 1 deletion lib/src/main/java/com/basistheory/elements/constants/CoBadgedSupport.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.basistheory.elements.constants

enum class CoBadgedSupport(val value: String) {
CARTES_BANCAIRES("cartes-bancaires");
CARTES_BANCAIRES("cartes_bancaires");

companion object {
fun fromString(value: String): CoBadgedSupport? {
Expand Down
3 changes: 0 additions & 3 deletions lib/src/main/java/com/basistheory/elements/view/CardNumberElement.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,11 @@ import com.basistheory.elements.event.EventDetails
import com.basistheory.elements.model.BinDetails
import com.basistheory.elements.model.CardMetadata
import com.basistheory.elements.model.InputType
import com.basistheory.elements.service.ApiClientProvider
import com.basistheory.elements.service.CardBrandEnricher
import com.basistheory.elements.util.BinDetailsCache
import com.basistheory.elements.view.mask.ElementMask
import com.basistheory.elements.view.transform.RegexReplaceElementTransform
import com.basistheory.elements.view.validation.LuhnValidator
import com.basistheory.resources.enrichments.requests.EnrichmentsGetCardDetailsRequest
import com.basistheory.types.CardDetailsResponse
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.Job
Expand Down
Loading