Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the test infrastructure from make-based test running to using pytest and tox. Key changes include the addition of a tox.toml configuration file, converting one test file to use the new testing framework, and updating pyproject.toml with dependency and Python version changes.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tox.toml | New tox configuration file defining environments for tests, docs, and formatting |
| tests/test_array.py | Updated and expanded tests for array and record behavior |
| tests/cli.py | Added CLI parsing helpers and test decorators |
| pyproject.toml | Updated project metadata and dependencies |
| conftest.py | Added a pytest option for quick test runs |
Files not reviewed (1)
- tests/README: Language not supported
Comments suppressed due to low confidence (1)
tests/cli.py:25
- [nitpick] The parameter name 'etp' is ambiguous. Consider renaming it to a more descriptive name such as 'should_pass' to improve clarity.
def __init__(self, etp, msg):
| description = "build documentation" | ||
| basepython = ["py312"] | ||
| skip_install = true | ||
| deps = "sphinx>=4" |
There was a problem hiding this comment.
[nitpick] For consistency with other environments that use lists for dependencies, consider changing the docs environment deps to a list format (e.g., deps = ["sphinx>=4"]).
Suggested change
| deps = "sphinx>=4" | |
| deps = ["sphinx>=4"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial project uses
makefor test running. The python ecosystem has pytest as a testing framework and tox for managing virtual environments. This PR attempts to start the migration to these by converting one test file to use these tools.