docs: fix typos #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
commented
Jul 8, 2023
| There are a couple of things going on here, so let's break it down. | ||
|
|
||
| First of all, it's worth noticing that **we changed the return type** of the function to `String`. This obbeys to two different reasons: | ||
| First of all, it's worth noticing that **we changed the return type** of the function to `String`. This is for two different reasons: |
Contributor
Author
There was a problem hiding this comment.
This was the only change I couldn't quite figure out what "obbeys" was trying to say, hope the semantics make sense.
Member
There was a problem hiding this comment.
Yes, totally makes sense, Thank you for the fix @robjtede ❤️
piny4man
approved these changes
Jul 10, 2023
Member
piny4man
left a comment
piny4man
left a comment
There was a problem hiding this comment.
Thanks for taking care and fix some typos around the documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.