feat(optimizer): Created TypeTransformer and related traits. Removed Optimizer struct.#43
Conversation
…tions to be TypeTransformers.
Bergmann89
left a comment
Bergmann89
left a comment
There was a problem hiding this comment.
In general it looks good to me. Nice work 👍 Just added some comment about small details and the github workflow is failing (clippy and I guess the doc step will also fail, because there are invalid references in the inline documentation after the refactoring).
lukasfri
changed the title
lukasfri
changed the title
|
Should be ready for merge now. |
… apply_transformer_if.
Bergmann89
left a comment
Bergmann89
left a comment
There was a problem hiding this comment.
LGTM. Just the checks needs to be fixed :)
I forgot what you wanted me to do. Rebase on xsd-toolkit branch? |
|
I initially thought a rebase was necessary to get the checks running for this PR, but it seems to be working without it. The only thing left to do is fix the checks, and then we’re ready to merge! :) |
|
Ah damn I didn't see cargo fmt not passing. I run cargo fmt on save so not quite sure how it is not already fixed. Should be sorted when I get home in 30 min, sorry for the extended back and forth. :/ |
|
No worries. Take your time :) |
|
58th times the charm |
2 participants
Rewrote optimization functions to be TypeTransformers.
Requires documentation.