Skip to content

Conversation

@bonachea
Copy link
Member

@bonachea bonachea commented Nov 12, 2024

Previously the assert library assumed flang is single-image and all other compilers are multi-image.

Factor that assumption into a new feature macro called ASSERT_MULTI_IMAGE that can be explicitly overridden by the client via fpm --flag to force single-image or multi-image support.

Assert on Flang continues to default to single-image.

Change Assert on Intel Fortran to default to single-image. This removes the need for the -coarray argument and the dependence on Intel MPI.

Use it to disable multi-image execution by default on Intel,
which in turn removes the dependence on Intel MPI

Adjust test code accordingly
@bonachea bonachea marked this pull request as ready for review November 12, 2024 20:00
@bonachea bonachea requested a review from rouson November 20, 2024 18:29
Copy link
Contributor

@rouson rouson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rouson rouson merged commit 98cd3ef into BerkeleyLab:main Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants