Skip to content

Increased the sso login timelimit to 10 minutes from 30 sec#104

Merged
sarosejoshi merged 1 commit intodevelopfrom
refactor/sanjog/sso
Jul 1, 2025
Merged

Increased the sso login timelimit to 10 minutes from 30 sec#104
sarosejoshi merged 1 commit intodevelopfrom
refactor/sanjog/sso

Conversation

@sanjog-lama
Copy link
Contributor

@sanjog-lama sanjog-lama commented Jul 1, 2025

Description

  • Increased the sso login timelimit to 10 mins from 30 secs.

Summary by CodeRabbit

  • Improvements
    • Increased timeout durations for AWS configuration checks and process termination, reducing the likelihood of premature timeouts.
    • Extended the allowed time for AWS SSO login processes, providing users with more time to complete interactive authentication steps.

@sanjog-lama sanjog-lama requested a review from sarosejoshi July 1, 2025 09:11
@coderabbitai
Copy link

coderabbitai bot commented Jul 1, 2025

Walkthrough

Timeout durations were increased in several internal methods: the AWS configuration check and process termination timeouts were extended from 2 to 5 seconds, while the AWS SSO login timeouts were raised from 30 seconds to 10 minutes. No changes were made to method signatures or error handling.

Changes

File(s) Change Summary
internal/common/services.go Increased context timeout in IsAWSConfigured from 2s to 5s.
internal/sso/client.go,
internal/sso/session.go
Increased AWS SSO login context timeout from 30s to 10min in SSOLogin and runSSOLogin.
utils/common/common.go Increased process termination wait timeout from 2s to 5s in terminateProcess.

Poem

The clocks tick slower, timeouts now grow,
Five seconds for checks, and for processes too—
SSO logins may linger, ten minutes to show,
More patient, more gentle, for all that we do.
🕰️🌱


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 9892cf0 and 0306d0e.

📒 Files selected for processing (4)
  • internal/common/services.go (1 hunks)
  • internal/sso/client.go (1 hunks)
  • internal/sso/session.go (1 hunks)
  • utils/common/common.go (1 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sarosejoshi sarosejoshi merged commit 4e50695 into develop Jul 1, 2025
1 check passed
@sarosejoshi sarosejoshi deleted the refactor/sanjog/sso branch July 1, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants