Skip to content

Eks cmd now will prompt for region and profile only#106

Merged
sarosejoshi merged 1 commit intodevelopfrom
refactor/sanjog/eks
Jul 2, 2025
Merged

Eks cmd now will prompt for region and profile only#106
sarosejoshi merged 1 commit intodevelopfrom
refactor/sanjog/eks

Conversation

@sanjog-lama
Copy link
Contributor

@sanjog-lama sanjog-lama commented Jul 2, 2025

Description

  • The awsctl eks command now prompts for region and profile only when SSO is configured.
  • Test cases have been updated to reflect these changes.

Note: Profile selection has not been removed because multiple profiles may exist, and the EKS cluster is fetched dynamically based on the selected profile and region. If only one profile is available, it is automatically selected. If multiple profiles are configured, a list of available profiles is displayed for selection.

Summary by CodeRabbit

  • Refactor

    • Simplified the workflow for updating EKS kubeconfig and retrieving cluster details, reducing interactive prompts and streamlining user actions.
  • Tests

    • Consolidated and simplified the test suite, focusing on core success and failure scenarios.
    • Removed numerous granular test cases and added new tests that cover higher-level behaviors.

@sanjog-lama sanjog-lama requested a review from sarosejoshi July 2, 2025 06:34
@coderabbitai
Copy link

coderabbitai bot commented Jul 2, 2025

Walkthrough

The EKSService flow was simplified by removing interactive action selection and confirmation prompts, streamlining the process to directly update kubeconfig and retrieve cluster details. Corresponding tests were refactored, consolidating and removing granular error scenario tests in favor of broader, higher-level cases with fewer mocks and simplified control flow.

Changes

File(s) Change Summary
internal/eks/eks.go Simplified Run method by removing action loop and prompts; removed confirmation prompt in cluster detail retrieval; removed unused errors import.
internal/eks/eks_test.go Refactored and consolidated tests: removed granular error scenario tests, added broader tests for main flows, updated test naming, and reduced mocks.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant EKSService
    participant ConnProvider
    participant AWSConfig
    participant EKSClient

    User->>EKSService: Run()
    EKSService->>EKSService: HandleKubeconfigUpdate()
    EKSService->>ConnProvider: GetDefaultRegion()
    alt Region available
        EKSService->>AWSConfig: LoadConfig(region, profile)
        AWSConfig->>EKSService: Return config or error
        EKSService->>EKSClient: ListClusters()
        EKSClient->>EKSService: Return clusters or error
        EKSService->>User: Prompt for cluster selection
    else Region not available or error
        EKSService->>User: Prompt for manual cluster input
    end
Loading

Poem

A hop and a skip, the prompts disappear,
No more loops or choices here.
Tests now lighter, mocks less dense,
The EKSService flow makes perfect sense.
With clusters found or entered by hand,
This code now runs just as planned!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 4cab471 and 89cc9d0.

📒 Files selected for processing (2)
  • internal/eks/eks.go (2 hunks)
  • internal/eks/eks_test.go (7 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sarosejoshi sarosejoshi merged commit 2a4d75b into develop Jul 2, 2025
1 check passed
@sanjog-lama sanjog-lama deleted the refactor/sanjog/eks branch July 2, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants