Skip to content

Removed prompt to set profile as default on sso init #112

Merged
sarosejoshi merged 1 commit intodevelopfrom
feat/sanjog/sso-init
Jul 3, 2025
Merged

Removed prompt to set profile as default on sso init #112
sarosejoshi merged 1 commit intodevelopfrom
feat/sanjog/sso-init

Conversation

@sanjog-lama
Copy link
Contributor

@sanjog-lama sanjog-lama commented Jul 3, 2025

Description

  • Removed the prompt to set the selected profile as default, this will now automatically set the selected profile as default
  • Made some refactor of code related to sso init

Summary by CodeRabbit

  • New Features

    • Added the ability to set an SSO profile as the default AWS profile.
    • Introduced a profile summary display feature, showing key SSO configuration details and account information.
  • Refactor

    • Streamlined the SSO initialization process for improved clarity and maintainability.

@sanjog-lama sanjog-lama requested a review from sarosejoshi July 3, 2025 09:46
@coderabbitai
Copy link

coderabbitai bot commented Jul 3, 2025

Walkthrough

Two new helper methods, setProfileAsDefault and printProfileSummary, were introduced in the SSO client implementation. The InitSSO method was refactored to delegate profile configuration and summary printing to these helpers, simplifying its logic. The import of the time package was adjusted accordingly.

Changes

File(s) Change Summary
internal/sso/profile.go Added setProfileAsDefault and printProfileSummary methods; imported time package for formatting.
internal/sso/sso.go Refactored InitSSO to use new helper methods; removed direct token expiry and config retrieval logic; removed unused time import.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SSOClient
    participant AWSConfig
    participant AWSSTS
    participant SSOAccount

    User->>SSOClient: InitSSO(profile)
    SSOClient->>SSOClient: setProfileAsDefault(profile)
    SSOClient->>AWSConfig: Retrieve SSO config values
    AWSConfig-->>SSOClient: Return config values
    SSOClient->>AWSConfig: configureAWSProfile("default", values)
    AWSConfig-->>SSOClient: Confirm profile set
    SSOClient->>SSOClient: printProfileSummary(profile)
    SSOClient->>AWSConfig: Retrieve SSO config values
    SSOClient->>AWSSTS: AwsSTSGetCallerIdentity(profile)
    AWSSTS-->>SSOClient: Return role ARN
    SSOClient->>SSOAccount: GetSSOAccountName(account_id)
    SSOAccount-->>SSOClient: Return account name
    SSOClient->>AWSConfig: GetCachedSsoAccessToken(profile)
    AWSConfig-->>SSOClient: Return token expiry
    SSOClient->>User: printSummary(...)
Loading

Poem

A hop and a skip in the SSO code,
Helpers now lighten the rabbit’s load.
Profiles set default with a single call,
Summaries print with no hassle at all.
With paws on the keyboard, I cheer and I beam,
For cleaner SSO—what a hoppy dream! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between dbc4ba7 and 9957876.

📒 Files selected for processing (2)
  • internal/sso/profile.go (2 hunks)
  • internal/sso/sso.go (2 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sarosejoshi sarosejoshi merged commit 90ee489 into develop Jul 3, 2025
1 check passed
@sanjog-lama sanjog-lama deleted the feat/sanjog/sso-init branch July 4, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants