Remove failing patches for react-native-video #118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisglein
added a commit
to chrisglein/AdaptiveCards
that referenced
this pull request
Mar 24, 2023
Workaround while waiting for BigThinkcode#118
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #115
Description
Removed the patch to
react-native-video, and with it the need forpatch-packageentirely. This addresses the merge conflict resulting fromreact-native-videochanges made since that patch was originally made in September as part of the move to 0.68.2 #93. Presumably from video version 5.2.1 (maybe was for this fix?)Sample Card
N/A
How Verified
Verified that after taking the change, a
yarncommand no longer fails with the error message.Additionally redirected an RN Windows app to a fork with only this change and the app is able to successfully render a simple card.