Fix Android Runtime Error #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Could you run |
Contributor
Author
|
For sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a build script for
firewheel-cpalwhich imports/locates in the binary the shared C++ STL, which is currently required for firewheel-cpal on Android, as CPAL needs C++ full collection of symbols, but at default oboe tends to import a static C++ STL, which is optimized away by the compiler (so we get an error of type: "dynamic linker is unable to find symbol ..."). This is why we need to explicitly state to import a shared C++ STL on Android.I'll look at CPAL future releases to update/remove this build script if outdated/redundant, as CPAL seems migrating from oboe, but I don't know how much time it will take and if a fallbacks for older devices will be set, so two options in the future are update (e.g. refine the build script for older devices) and remove (if CPAL removes all C++ ffi needs)