fix(build): key-utils as pure TS package + fix remote miniapp icon URLs #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change key-utils to export src/*.ts directly (no build needed) - Fix remote miniapp icon/screenshot URL handling with proper URL check - Absolute URLs (http/https) are preserved, relative paths use new URL()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@biochain/key-uitypecheck 失败问题Changes
packages/key-utils/package.jsonsrc/*.ts（纯 TS 包，无需 build）scripts/vite-plugin-miniapps.tsnew URL()处理相对路径，保留绝对 URLWhy
key-utils是纯工具函数包，不需要编译，直接导出源码即可icon可能是绝对 URL（如https://...），之前的字符串拼接会生成错误路径如./rwa-hub/https://...