Fix deadlock error from C++ 20 #143
Merged
+10
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`absl::SetMutexDeadlockDetectionMode(absl::OnDeadlockCycle::kIgnore);` fixes ODBC deadlock issue. We turn off the detection as the deadlock originated from upstream projects.
alinaliBQ
commented
Jan 5, 2026
Comment on lines
+351
to
354
| ARROW_HOME: /usr | ||
| CMAKE_GENERATOR: Ninja | ||
| CMAKE_INSTALL_PREFIX: /usr |
Author
There was a problem hiding this comment.
ARROW_HOME and CMAKE_INSTALL_PREFIX should match, so I fixed it
alinaliBQ
commented
Jan 5, 2026
Comment on lines
41
to
44
| RegisterLog(); | ||
| // GH-48637: Disable Absl Deadlock detection from upstream projects | ||
| absl::SetMutexDeadlockDetectionMode(absl::OnDeadlockCycle::kIgnore); | ||
| } |
Author
There was a problem hiding this comment.
The potential deadlock errors started appearing after C++ 20 is enabled. I don't know the root cause, but this line disables the deadlock detection and resolves the issue. Arrow community has confirmed that absl is not used directly in Arrow project, so the error likely came from gRPC.
justing-bq
approved these changes
Jan 5, 2026
Attempt to resolve caching issue with ODBC CI Add write permission to store vcpkg cache Check nuget paths in Ruby Glib and ODBC Run vcpkg install after vcpkg is set in GLib Enable vcpkg verbose in GLib * confirmed `vcpkg install` command returns 403 error Add ARROW_HOME Remove `ARROW_SIMD_LEVEL` as it is not required for ODBC. Remove debug msgs Cannot get vcpkg in cpp_build to show debug messages Move location of `packages: write` Attempt to add `ARROW_DEPENDENCY_USE_SHARED - off` Revert "Move location of `packages: write`" This reverts commit b62e04e. Revert "Attempt to add `ARROW_DEPENDENCY_USE_SHARED - off`" This reverts commit 5fdf425. Add GLib MSVC build to C++ Extra TEMP disable ODBC build Disable cmake and enable build Re-enable cmake 4.1.2 and use install_vcpkg.sh to install vcpkg Clean up test changes Push after previous run is complete. Revert "Re-enable cmake 4.1.2 and use install_vcpkg.sh to install vcpkg" This reverts commit dfea377. Trigger CI Apply Kou's suggestion for nuget timeout
alinaliBQ
force-pushed
the
fix-deadlock-issue-cxx20
branch
from
1ef3c39 to
53fea11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deadlock issue in C++ 20 by disabling deadlock detection. See apache#48714 for discussion and more context; Arrow doesn't use Absl directly, so the
potential deadlockerror is from upstream projects and not Arrow itself.Fix slow CI time by resolving cache issues.