Adjust tests for MacOS #147
Conversation
| // Test disabled until we resolve bus error on MacOS | ||
| #ifdef DISABLE_TEST |
There was a problem hiding this comment.
Could you raise an internal Jira for this? If we plan to export this change to the Arrow repo, we need to raise a GitHub issue for this as well.
There was a problem hiding this comment.
| sqlite3_column_text(schema_statement->GetSqlite3Stmt(), 0))); | ||
|
|
||
| if (table_columns_map.contains(table_name)) { | ||
| const char* column_name = reinterpret_cast<const char*>( |
There was a problem hiding this comment.
Just curious, is this a bug that only occurs on mac and not Windows?
There was a problem hiding this comment.
The logic for iterating through all the columns happens inside the while (sqlite3_step(schema_statement->GetSqlite3Stmt()) == SQLITE_ROW) loop. On Windows we can go through this loop multiple times which is why the loop was nested inside another loop iterating through the tables. But on MacOS, this loop will only run all the way through once. So I rewrote this logic to only go through the loop once using a map to sort out which columns belong to which table. This new logic works for both Windows and MacOS.
justing-bq
force-pushed
the
macOsFix
branch
2 times, most recently
from
b250272 to
52cc4b1
Compare
justing-bq
force-pushed
the
macOsFix
branch
8 times, most recently
from
e48c57a to
0ccab8d
Compare
Rationale for this change
Changes need to be made to get the tests passing on MacOS.
What changes are included in this PR?
Adjusted tests so they will pass on MacOS.
Rewrote some sqlite logic so it will work on both Windows and Mac.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.