Skip to content

better _decode_outputs #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
afk11 merged 2 commits into from
Mar 9, 2015
Merged

better _decode_outputs #68

afk11 merged 2 commits into from
Mar 9, 2015

Conversation

@rubensayshi
Copy link
Member

@rubensayshi rubensayshi commented Mar 2, 2015

  • throw exception when trying to read bytes that aren't there.
  • no longer need the 'manual' strlen checks.

Fixes #67

@rubensayshi
throw exception when trying to read bytes that aren't there.
60a16e0 
no longer need the 'manual' strlen checks.
@rubensayshi rubensayshi mentioned this pull request Mar 2, 2015
Open
@afk11
Copy link
Member

afk11 commented Mar 9, 2015

Sweet, thanks!

afk11 added a commit that referenced this pull request Mar 9, 2015
@afk11
Merge pull request #68 from blocktrail/decode-strlen
a56f74c 
better _decode_outputs
@afk11 afk11 merged commit a56f74c into Bit-Wasp:master Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

decode fails at _decode_outputs sufficient length check throwing error on valid transaction

2 participants

@rubensayshi @afk11