Changes in Yearbook #100
Merged
Changes in Yearbook #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Mihir-solanki-13
commented
Sep 13, 2022
Mihir-solanki-13
commented
- Now search field (roll no /name) is not required in the year-book
- Change Get to Post method
- commented some useless codes and functions for deprecation
tushhr
reviewed
Sep 13, 2022
applications/members/views.py
Outdated
| if len(request.POST) > 1: | ||
| if request.POST['search'] != '': | ||
| key = request.POST['search'] | ||
| profiles = Profile.objects.filter(name__icontains=key) | Profile.objects.filter( |
Member
There was a problem hiding this comment.
We don't have to call all data again, just apply the filter on profiles, that would be fine.
applications/members/urls.py
Outdated
| path('autosearch/', views.autoSearch, name='autosearch'), | ||
| path('mapsearch/', views.mapSearch, name='mapsearch'), | ||
| # path('autosearch/', views.autoSearch, name='autosearch'), | ||
| # path('mapsearch/', views.mapSearch, name='mapsearch'), |
tushhr
added a commit
that referenced
this pull request
Sep 14, 2022
* Search field changes * Proper error and messages * Incremental changes Co-authored-by: Tushhr <tusharmaheshwaritm6@gmail.com>
tushhr
pushed a commit
that referenced
this pull request
Sep 14, 2022
* Search field changes * Proper error and messages * Incremental changes Co-authored-by: Tushhr
tushhr
pushed a commit
that referenced
this pull request
Sep 14, 2022
* Search field changes * Proper error and messages * Incremental changes Co-authored-by: Tushhr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.