Incorporate API changes #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bpdavenport
commented
Sep 20, 2014
bpdavenport
commented
- addresses -> wallets
- keychain API changes
- wallet API changes
- addresses -> wallets - keychain API changes - wallet API changes
tylerlevine
pushed a commit
that referenced
this pull request
Mar 25, 2020
A common use case in the front end is building a URL to a block explorer for a specific transaction, so a user can see the status of their transaction on chain. For some account coins, fees are paid from the Enterprise, instead of from the wallet itself. For those coins, we'd like to be able to: 1) Know that this is one of those coins where the enterprise pays fees 2) How to build an explorer URL so a user can look at the on chain balance of their Enterprise fee address This commit adds the ENTEPRISE_PAYS_FEES coin feature, and adds this feature to XTZ and ETH (the only two coins which currently pay fees from the Enterprise gas tank). This solves for case #1. This commit also adds a new optional field to `AccountNetwork` called `accountExplorerUrl`. This can be used for building urls just like the `explorerUrl`, and therefore solves case #2 above. Ticket: BG-19107
dhoffmann
pushed a commit
that referenced
this pull request
Apr 27, 2021
* add testnet bip49 example * Should be able to deal with incomplete P2SH/P2WSH inputs when allowIncomplete is set * remove redundant baddress.toOutputScript call from tests * set p2sh=true only if redeemScriptType is set * testing/integration/examples: isolate to addresses/transactions examples, use public broadcast endpoints * tests/integration: add BIP32 serialization and multi-child examples * README: re-generate examples list * README: drop Contributors * README: add bech32 * README: move BCoin to Alternative * README: drop insight * README: add helperbit * LICENSE: 2017 too * add from/toBech32 * add Bech32 support to toOutputScript/fromOutputScript * README/tests: add BIP173/BIP16 SegWit address examples * tests: add P2WPK, P2WSH spend example * tests: resist txn-mempool-conflicts * tests/txb: add P2WSH(multisig), incomplete fixture * txbuilder: refactor branches for readability * add witnessPubKeyHash compressed policy * templates/pubkey: only canonical pubkeys to encode * TxBuilder: restrict uncompressed keyPairs for P2WPK and P2WSH * script: use asMinimalOP for ASM/decompile * Fix the integration url's to latest version also some of the urls were broken * add bech32 fixture * Fixed Segwit links The links were redirecting to 404 - I've modified them so they adhere to the beginning of the respective Segwit unit tests. * Fixed some README links Found some more links that were displaced by the Segwit unit tests and fixed them * typescript instructions on README closes: bitcoinjs/bitcoinjs-lib#815 * README: cleanup typescript help * Add witness is true to signing * Add test for witness = true edge case during multisigning * TransactionBuilder: collect witnessValue as input.value, and match it * Fix txb.__overMaximumFees for segwit * Add test case * Fix absurd fee in fixture * buildstack - don't return op_0 * multisig.input.encodestack - replace OP_0 (permitted by partialSignature) with EMPTY_BUFFER * update CHANGELOG * 3.2.0 * tests: script tests can validate template fixtures too * match scriptHash types 1 for 1, ignore classify order * add fixture to verify input type classification (cherry picked from commit 8f9d8b7) * respond to Jonathan Underwood's comments (cherry picked from commit 8126ca2) * tests/fixtures: amend truncated outputHex * README: add notes about ES5, Node LTS feature tracking * package: rm contributors field, outdated, update wallet estimate * rm bscript circular dependencies * txbuilder: fix canSign returning true for missing witness value * address/txbuilder: require templates to prevent undefined exports * tests: add passing and failing tests for witness*.input.encode/decode * witnessScriptHash: fixed implementation * tests: add failing staged transaction building example #901 * txbuilder: apply input.value before prepareInput * s/checkP2shInput/checkP2SHInput * 3.2.1 * ECSignature: add toRSBuffer/fromRSBuffer * TxBuilder: add support for RSBuffer type keyPairs and .publicKey * 3.3.0 * tests: txb for TxBuilder, Tx for Transaction * increase max feerate sanity check from 1000 to 2500 * 3.3.1 * opt-in bitcoin-cash support in transaction_builder * TransactionBuilder.fromTransaction & Bitcoin Cash Adds an extra parameter to fromTransaction, which tells the library to expect a value property to be added on each txin which uses bitcoin cash's sighashtype * bitcoin gold support * package: rename to bitcoinforksjs-lib
dhoffmann
pushed a commit
that referenced
this pull request
Apr 27, 2021
* Add initial dash support
* Bump version to `1.1.0`
* README: Mention Dash support
* Add Dash mainnet signing tests
```
addr:
Xm8Ybuu5VKT4nWWBKeiHtyRWHkwjupgfFq
XjiSnSr1w2k1UAedyG7LQGQYsA1uj3m5LY
XgaacWH3KxQ1BfzQqsM6JB52khdxz7g1Pk
pubkey:
02fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d
0363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db7611
035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac
privkey:
XDG95UrXfoy1sRtfftWhbcwJD4U5FZj1nR1rhqzNf43CzkEAvESU
XHpynJEvTASKUfdWx2eLWmQgGEeumifNhoJheU7tbJVZXwWcuKJm
XJm6ARhk2jdGiAzDLTnkUtagCFjgW8DEQqsvQk4iQG7CEubHmgey
> ./bin/dash-cli createmultisig 2 '["02fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d", "0363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db7611", "035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac"]'
{
"address": "7Ykeu1WsHjYGjjN7MmM4LAaVsKqLUMmL4U",
"redeemScript": "522102fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d210363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db761121035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac53ae"
}
Funding transaction:
8589b1372f928bf40e5fa434bb2df7f4d6b0c0ff8c698ed1573099bc385446f2
our vout:
"vout": [
{
"value": 0.00200000,
"valueSat": 200000,
"n": 0,
"scriptPubKey": {
"asm": "OP_HASH160 45993167724a9ca98d966d1bbd2eabd1b58d9827 OP_EQUAL",
"hex": "a91445993167724a9ca98d966d1bbd2eabd1b58d982787",
"reqSigs": 1,
"type": "scripthash",
"addresses": [
"7Ykeu1WsHjYGjjN7MmM4LAaVsKqLUMmL4U"
]
}
},
Dash deposit on binance:
XraCLqKneazAxKyEY7TDMXwaATZ89HgfNf
dash-cli createrawtransaction '[{"txid":"8589b1372f928bf40e5fa434bb2df7f4d6b0c0ff8c698ed1573099bc385446f2","vout":0,"scriptPubKey":"a91445993167724a9ca98d966d1bbd2eabd1b58d982787","redeemScript":"522102fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d210363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db761121035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac53ae"}]' '{"XraCLqKneazAxKyEY7TDMXwaATZ89HgfNf":0.0019}'
./bin/dash-cli createrawtransaction '[{"txid":"8589b1372f928bf40e5fa434bb2df7f4d6b0c0ff8c698ed1573099bc385446f2","vout":0,"scriptPubKey":"a91445993167724a9ca98d966d1bbd2eabd1b58d982787","redeemScript":"522102fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d210363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db761121035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac53ae"}]' '{"XraCLqKneazAxKyEY7TDMXwaATZ89HgfNf":0.002}'
0200000001f2465438bc993057d18e698cffc0b0d6f4f72dbb34a45f0ef48b922f37b189850000000000ffffffff01400d0300000000001976a914ae4038c16a7a946e5d880f7ba74278ca24ea724588ac00000000
signrawtransaction '0200000001f2465438bc993057d18e698cffc0b0d6f4f72dbb34a45f0ef48b922f37b189850000000000ffffffff01400d0300000000001976a914ae4038c16a7a946e5d880f7ba74278ca24ea724588ac00000000' '[{"txid":"8589b1372f928bf40e5fa434bb2df7f4d6b0c0ff8c698ed1573099bc385446f2","vout":0,"scriptPubKey":"a91445993167724a9ca98d966d1bbd2eabd1b58d982787","redeemScript":"522102fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d210363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db761121035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac53ae"}]' '["XDG95UrXfoy1sRtfftWhbcwJD4U5FZj1nR1rhqzNf43CzkEAvESU"]'
first sign:
./bin/dash-cli signrawtransaction '0200000001f2465438bc993057d18e698cffc0b0d6f4f72dbb34a45f0ef48b922f37b189850000000000ffffffff01400d0300000000001976a914ae4038c16a7a946e5d880f7ba74278ca24ea724588ac00000000' '[{"txid":"8589b1372f928bf40e5fa434bb2df7f4d6b0c0ff8c698ed1573099bc385446f2","vout":0,"scriptPubKey":"a91445993167724a9ca98d966d1bbd2eabd1b58d982787","redeemScript":"522102fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d210363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db761121035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac53ae"}]' '["XDG95UrXfoy1sRtfftWhbcwJD4U5FZj1nR1rhqzNf43CzkEAvESU"]'
{
"hex": "0200000001f2465438bc993057d18e698cffc0b0d6f4f72dbb34a45f0ef48b922f37b1898500000000b40047304402200685dca480d2fbdede321e6a8dacc495105b77d13ed1050d097f74fd297efbaa0220141209e112e838036bdf1757a7984df21df23fd735c77a9f2ad1025f1ee7af65014c69522102fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d210363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db761121035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac53aeffffffff01400d0300000000001976a914ae4038c16a7a946e5d880f7ba74278ca24ea724588ac00000000",
"complete": false,
"errors": [
{
"txid": "8589b1372f928bf40e5fa434bb2df7f4d6b0c0ff8c698ed1573099bc385446f2",
"vout": 0,
"scriptSig": "0047304402200685dca480d2fbdede321e6a8dacc495105b77d13ed1050d097f74fd297efbaa0220141209e112e838036bdf1757a7984df21df23fd735c77a9f2ad1025f1ee7af65014c69522102fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d210363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db761121035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac53ae",
"sequence": 4294967295,
"error": "Operation not valid with the current stack size"
}
]
}
signrawtransaction '0200000001f2465438bc993057d18e698cffc0b0d6f4f72dbb34a45f0ef48b922f37b1898500000000b40047304402200685dca480d2fbdede321e6a8dacc495105b77d13ed1050d097f74fd297efbaa0220141209e112e838036bdf1757a7984df21df23fd735c77a9f2ad1025f1ee7af65014c69522102fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d210363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db761121035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac53aeffffffff01400d0300000000001976a914ae4038c16a7a946e5d880f7ba74278ca24ea724588ac00000000' '[{"txid":"8589b1372f928bf40e5fa434bb2df7f4d6b0c0ff8c698ed1573099bc385446f2","vout":0,"scriptPubKey":"a91445993167724a9ca98d966d1bbd2eabd1b58d982787","redeemScript":"522102fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d210363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db761121035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac53ae"}]' '["XHpynJEvTASKUfdWx2eLWmQgGEeumifNhoJheU7tbJVZXwWcuKJm"]'
./bin/dash-cli signrawtransaction '0200000001f2465438bc993057d18e698cffc0b0d6f4f72dbb34a45f0ef48b922f37b1898500000000b40047304402200685dca480d2fbdede321e6a8dacc495105b77d13ed1050d097f74fd297efbaa0220141209e112e838036bdf1757a7984df21df23fd735c77a9f2ad1025f1ee7af65014c69522102fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d210363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db761121035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac53aeffffffff01400d0300000000001976a914ae4038c16a7a946e5d880f7ba74278ca24ea724588ac00000000' '[{"txid":"8589b1372f928bf40e5fa434bb2df7f4d6b0c0ff8c698ed1573099bc385446f2","vout":0,"scriptPubKey":"a91445993167724a9ca98d966d1bbd2eabd1b58d982787","redeemScript":"522102fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d210363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db761121035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac53ae"}]' '["XHpynJEvTASKUfdWx2eLWmQgGEeumifNhoJheU7tbJVZXwWcuKJm"]'
{
"hex": "0200000001f2465438bc993057d18e698cffc0b0d6f4f72dbb34a45f0ef48b922f37b1898500000000fc0047304402200685dca480d2fbdede321e6a8dacc495105b77d13ed1050d097f74fd297efbaa0220141209e112e838036bdf1757a7984df21df23fd735c77a9f2ad1025f1ee7af650147304402203f205962349dc4da062c15b73126b38f5e5e8016fe317e3dcb59bcdded117fbd022036386f24da402f821d259557b521561d78079069f5c80f4c8993a8a8af610e83014c69522102fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d210363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db761121035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac53aeffffffff01400d0300000000001976a914ae4038c16a7a946e5d880f7ba74278ca24ea724588ac00000000",
"complete": true
}
```
```
createrawtransaction '[{"txid":"8589b1372f928bf40e5fa434bb2df7f4d6b0c0ff8c698ed1573099bc385446f2","vout":0,"scriptPubKey":"a91445993167724a9ca98d966d1bbd2eabd1b58d982787","redeemScript":"522102fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d210363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db761121035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac53ae"}]' '{"XraCLqKneazAxKyEY7TDMXwaATZ89HgfNf":0.0019}'
0200000001f2465438bc993057d18e698cffc0b0d6f4f72dbb34a45f0ef48b922f37b189850000000000ffffffff0130e60200000000001976a914ae4038c16a7a946e5d880f7ba74278ca24ea724588ac00000000
signrawtransaction '0200000001f2465438bc993057d18e698cffc0b0d6f4f72dbb34a45f0ef48b922f37b189850000000000ffffffff0130e60200000000001976a914ae4038c16a7a946e5d880f7ba74278ca24ea724588ac00000000' '[{"txid":"8589b1372f928bf40e5fa434bb2df7f4d6b0c0ff8c698ed1573099bc385446f2","vout":0,"scriptPubKey":"a91445993167724a9ca98d966d1bbd2eabd1b58d982787","redeemScript":"522102fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d210363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db761121035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac53ae"}]' '["XDG95UrXfoy1sRtfftWhbcwJD4U5FZj1nR1rhqzNf43CzkEAvESU"]'
0200000001f2465438bc993057d18e698cffc0b0d6f4f72dbb34a45f0ef48b922f37b1898500000000b500483045022100e3c06a8448983adf926359de08b0682357a3277a7b053a272aafaa1dc343af6b02205492b653adc286dae6992ecb176768c9b94c35929441d4ee94a4903d875ba9be014c69522102fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d210363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db761121035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac53aeffffffff0130e60200000000001976a914ae4038c16a7a946e5d880f7ba74278ca24ea724588ac00000000
signrawtransaction '0200000001f2465438bc993057d18e698cffc0b0d6f4f72dbb34a45f0ef48b922f37b1898500000000b500483045022100e3c06a8448983adf926359de08b0682357a3277a7b053a272aafaa1dc343af6b02205492b653adc286dae6992ecb176768c9b94c35929441d4ee94a4903d875ba9be014c69522102fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d210363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db761121035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac53aeffffffff0130e60200000000001976a914ae4038c16a7a946e5d880f7ba74278ca24ea724588ac00000000' '[{"txid":"8589b1372f928bf40e5fa434bb2df7f4d6b0c0ff8c698ed1573099bc385446f2","vout":0,"scriptPubKey":"a91445993167724a9ca98d966d1bbd2eabd1b58d982787","redeemScript":"522102fa7a51471c13df1b87ed6687be9ebc746b2801230592d7541061eddcc91c5b3d210363945f699f409787e6348b0bb5dbd0fe795cf7d0133ced5e13e8aa3c26db761121035ce5bf6521535490e39b6516e8c55986cf8bd13e33b8044a71ba61d3c8e01fac53ae"}]' '["XHpynJEvTASKUfdWx2eLWmQgGEeumifNhoJheU7tbJVZXwWcuKJm"]'
```
* Add tDash signing test
* Minor fixes to dash fixtures
* Fix Dash message prefix constant
bitgoandrew
added a commit
that referenced
this pull request
Feb 11, 2022
# This is the 1st commit message: feat(account-lib): add solana tokens STLX-11959 # The commit message #2 will be skipped: # feat(account-lib): es-lint fixes STLX-11959 # The commit message #3 will be skipped: # feat(account-lib): es-lint fixes again STLX-11959 # The commit message #4 will be skipped: # feat(account-lib): es-lint fixes again STLX-11959 # The commit message #5 will be skipped: # feat(account-lib): removing mint param docu STLX-11959 # The commit message #6 will be skipped: # feat(account-lib): fixing linter STLX-11959 # The commit message #7 will be skipped: # feat(account-lib): fixing linter STLX-11959
bitgoandrew
added a commit
that referenced
this pull request
Feb 11, 2022
# This is the 1st commit message: feat(account-lib): add solana tokens STLX-11959 # The commit message #2 will be skipped: # feat(account-lib): fixing linter3 STLX-11959 # The commit message #3 will be skipped: # feat(account-lib): fixing linter3 STLX-11959 # The commit message #4 will be skipped: # feat(account-lib): fixing linter4 STLX-11959
abhi-bitgo
added a commit
that referenced
this pull request
Aug 7, 2025
# This is the 1st commit message: feat(abstract-eth): add recover consolidation for eth ticket: WIN-5700 # This is the commit message #2: test: fix the unit test for hteth values ticket: WIN-5700 # This is the commit message #3: feat(abstract-eth): update the derive address logic for recovery ticket: WIN-5700 # This is the commit message #4: feat: add test cases and types ticket: WIN-5700 # This is the commit message #5: test: fix the missing value in test case ticket: WIN-5700 # This is the commit message #6: test: update the nocking calls ticket: WIN-5700 # This is the commit message #7: test: nock the api call for balance ticket: WIN-5700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.