Skip to content

chore(sdk-coin-polygon): move polygon to its own module #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bitgoAaron merged 2 commits into from
Jul 18, 2022
Merged

chore(sdk-coin-polygon): move polygon to its own module #2530

bitgoAaron merged 2 commits into from
Jul 18, 2022

Conversation

@mmcshinsky-bitgo
Copy link
Contributor

@mmcshinsky-bitgo mmcshinsky-bitgo commented Jul 15, 2022

@mmcshinsky-bitgo mmcshinsky-bitgo marked this pull request as ready for review July 15, 2022 23:04
@mmcshinsky-bitgo mmcshinsky-bitgo requested a review from a team July 15, 2022 23:04
@mmcshinsky-bitgo mmcshinsky-bitgo force-pushed the BG-52417-refactor-polygon-into-bitgo-sdk-coin-polygon branch from 517c3e5 to 75d7fed Compare July 16, 2022 18:50
bitgoAaron
bitgoAaron reviewed Jul 18, 2022
View reviewed changes
modules/sdk-coin-polygon/package.json Outdated
Copy link
Contributor

@bitgoAaron bitgoAaron Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing secp256k1 & bip32 from devDeps

Copy link
Contributor Author

@mmcshinsky-bitgo mmcshinsky-bitgo Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done :)

bitgoAaron
bitgoAaron reviewed Jul 18, 2022
View reviewed changes
modules/sdk-coin-polygon/package.json Outdated
Copy link
Contributor

@bitgoAaron bitgoAaron Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing @bitgo/sdk-statics

bitgoAaron
bitgoAaron reviewed Jul 18, 2022
View reviewed changes
modules/sdk-coin-polygon/tsconfig.json Outdated
Copy link
Contributor

@bitgoAaron bitgoAaron Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs "../statics"

bitgoAaron
bitgoAaron requested changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@bitgoAaron bitgoAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to fix missing dependencies, as well as review the CI check deps step because this should not have gotten a green build with missing @bitgo/statics

@mmcshinsky-bitgo mmcshinsky-bitgo force-pushed the BG-52417-refactor-polygon-into-bitgo-sdk-coin-polygon branch from 75d7fed to ca1ef43 Compare July 18, 2022 18:04
@mmcshinsky-bitgo
Copy link
Contributor Author

mmcshinsky-bitgo commented Jul 18, 2022

we need to fix missing dependencies, as well as review the CI check deps step because this should not have gotten a green build with missing @bitgo/statics

There was a bad check for dependencies in the dep-check. I've fixed that in the second commit of the PR.

@mmcshinsky-bitgo mmcshinsky-bitgo force-pushed the BG-52417-refactor-polygon-into-bitgo-sdk-coin-polygon branch from ca1ef43 to 5cc3255 Compare July 18, 2022 18:14
@bitgoAaron bitgoAaron merged commit 621d4fb into master Jul 18, 2022
@snyk-bot snyk-bot mentioned this pull request Oct 4, 2022
Closed
@Ernel1997 Ernel1997 mentioned this pull request Nov 26, 2023
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Nov 26, 2023
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Dec 20, 2023
Open
@Ernel1997 Ernel1997 mentioned this pull request Dec 20, 2023
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Feb 11, 2024
Open
@Ernel1997 Ernel1997 mentioned this pull request Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitgoAaron bitgoAaron bitgoAaron approved these changes

@argjv argjv Awaiting requested review from argjv

@CapnMigraine CapnMigraine Awaiting requested review from CapnMigraine

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmcshinsky-bitgo @bitgoAaron