Skip to content

chore(sdk-coin-eth2): move ETH2 to its own module #2531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bitgoAaron merged 3 commits into from
Jul 19, 2022
Merged

chore(sdk-coin-eth2): move ETH2 to its own module #2531

bitgoAaron merged 3 commits into from
Jul 19, 2022

Conversation

@bitgoAaron
Copy link
Contributor

@bitgoAaron bitgoAaron commented Jul 15, 2022

@bitgoAaron bitgoAaron requested a review from a team July 15, 2022 23:23
@bitgoAaron bitgoAaron requested a review from a team July 15, 2022 23:23
sachushaji
sachushaji reviewed Jul 18, 2022
View reviewed changes
@bitgoAaron bitgoAaron requested a review from sachushaji July 18, 2022 16:56
@bitgoAaron
chore(sdk-coin-eth2): project init
489df46 
- ETH2 project init

Ticket: BG-48151
@bitgoAaron
chore(sdk-coin-eth2): move code & tests
5802406 
- moves account-lib code & tests
- moves bitgo code & tests

Ticket: BG-48151
@bitgoAaron
chore(sdk-coin-eth2): fix unit tests
1cc206e 
- fixes typings & uncomments assertions

Ticket: BG-48151
sachushaji
sachushaji approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@sachushaji sachushaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @bitgoAaron

@bitgoAaron bitgoAaron merged commit 6b952d6 into master Jul 19, 2022
@snyk-bot snyk-bot mentioned this pull request Oct 4, 2022
Closed
@Ernel1997 Ernel1997 mentioned this pull request Nov 26, 2023
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Nov 26, 2023
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Dec 20, 2023
Open
@Ernel1997 Ernel1997 mentioned this pull request Dec 20, 2023
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Feb 11, 2024
Open
@Ernel1997 Ernel1997 mentioned this pull request Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sachushaji sachushaji sachushaji approved these changes

@mmcshinsky-bitgo mmcshinsky-bitgo mmcshinsky-bitgo approved these changes

@argjv argjv Awaiting requested review from argjv

@CapnMigraine CapnMigraine Awaiting requested review from CapnMigraine

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bitgoAaron @sachushaji @mmcshinsky-bitgo