Skip to content

feat(statics): remove 'kind' parameter from FIAT factory #2534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmcshinsky-bitgo merged 1 commit into from
Jul 19, 2022
Merged

feat(statics): remove 'kind' parameter from FIAT factory #2534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions modules/statics/src/account.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ export interface SolCoinConstructorOptions extends AccountConstructorOptions {
type FiatCoinName = `fiat${string}` | `tfiat${string}`;
export interface FiatCoinConstructorOptions extends AccountConstructorOptions {
name: FiatCoinName;
kind: CoinKind;
}

export interface ContractAddress extends String {
Expand Down Expand Up @@ -321,7 +320,7 @@ export class FiatCoin extends BaseCoin {
public readonly network: BaseNetwork;

constructor(options: FiatCoinConstructorOptions) {
super(options);
super({ ...options, kind: CoinKind.FIAT });

this.network = options.network;
}
Expand Down Expand Up @@ -1247,7 +1246,6 @@ export function tavaxErc20(
* @param prefix? Optional coin prefix. Defaults to empty string
* @param suffix? Optional coin suffix. Defaults to coin name.
* @param isToken? Whether or not this coin is a token of another coin
* @param kind? Differentiates coins which represent fiat assets from those which represent crypto assets
*/
export function fiat(
name: FiatCoinName,
Expand All @@ -1259,8 +1257,7 @@ export function fiat(
primaryKeyCurve: KeyCurve = KeyCurve.Secp256k1,
prefix = '',
suffix: string = name.toUpperCase(),
isToken = false,
kind: CoinKind = CoinKind.FIAT
isToken = false
) {
return Object.freeze(
new FiatCoin({
Expand All @@ -1274,7 +1271,6 @@ export function fiat(
isToken,
asset,
primaryKeyCurve,
kind,
})
);
}