chore: move usd and ofc coins to sdk-core

modules/account-lib/src/index.ts

@@ -56,9 +56,6 @@ export { Hbar };
 import { CsprLib as Cspr } from '@bitgo/sdk-coin-cspr';
 export { Cspr };
 
-import * as Xrp from './coin/xrp';
-export { Xrp };
-
 import { StxLib as Stx } from '@bitgo/sdk-coin-stx';
 export { Stx };
 
@@ -102,8 +99,6 @@ const coinBuilderMap = {
   thbar: Hbar.TransactionBuilderFactory,
   cspr: Cspr.TransactionBuilderFactory,
   tcspr: Cspr.TransactionBuilderFactory,
-  xrp: Xrp.TransactionBuilderFactory,
-  txrp: Xrp.TransactionBuilderFactory,
   stx: Stx.TransactionBuilderFactory,
   tstx: Stx.TransactionBuilderFactory,
   algo: Algo.TransactionBuilderFactory,

modules/bitgo/src/v2/coins/index.ts

@@ -55,14 +55,6 @@ export { Xtz, Txtz };
 import { Zec, Tzec } from '@bitgo/sdk-coin-zec';
 export { Zec, Tzec };
 
-
-export { Ofc } from './ofc'; // TODO: SDKT-15: make abstract and remove from exported list
-export { OfcToken } from './ofcToken';
-export { Susd } from './susd';
-export { FiatUsd } from './fiatusd';
-export { FiatEur } from './fiateur';
-export { FiatGBP } from './fiatgbp';
-export { Tsusd } from './tsusd';
-export { TfiatUsd } from './tfiatusd';
-export { TfiatEur } from './tfiateur';
-export { TfiatGBP } from './tfiatgbp';
+import { coins } from '@bitgo/sdk-core';
+const { Ofc, OfcToken, Susd, FiatUsd, FiatEur, FiatGBP, Tsusd, TfiatUsd, TfiatEur, TfiatGBP } = coins;
+export { Ofc, OfcToken, Susd, FiatUsd, FiatEur, FiatGBP, Tsusd, TfiatUsd, TfiatEur, TfiatGBP };

modules/sdk-coin-eth/src/eth.ts

@@ -21,7 +21,6 @@ import {
   FeeEstimateOptions,
   getIsKrsRecovery,
   getIsUnsignedSweep,
-  HalfSignedAccountTransaction,
   InvalidAddressError,
   InvalidAddressVerificationObjectPropertyError,
   IWallet,
@@ -38,13 +37,18 @@ import {
   VerifyAddressOptions as BaseVerifyAddressOptions,
   VerifyTransactionOptions,
   Wallet,
+  Recipient,
+  HalfSignedTransaction,
+  FullySignedTransaction,
 } from '@bitgo/sdk-core';
 
 import { BaseCoin as StaticsBaseCoin, EthereumNetwork, ethGasConfigs } from '@bitgo/statics';
 import type * as EthTxLib from '@ethereumjs/tx';
 import type * as EthCommon from '@ethereumjs/common';
 import { calculateForwarderV1Address, getProxyInitcode } from './lib';
 
+export { Recipient, HalfSignedTransaction, FullySignedTransaction };
+
 const debug = debugLib('bitgo:v2:eth');
 
 export const optionalDeps = {
@@ -118,12 +122,6 @@ interface HopPrebuild {
   gasPriceMax: number;
 }
 
-export interface Recipient {
-  address: string;
-  amount: string;
-  data?: string;
-}
-
 interface EIP1559 {
   maxPriorityFeePerGas: number;
   maxFeePerGas: number;
@@ -167,20 +165,6 @@ export interface SignTransactionOptions extends BaseSignTransactionOptions, Sign
   custodianTransactionId?: string;
 }
 
-export interface HalfSignedTransaction extends HalfSignedAccountTransaction {
-  halfSigned: {
-    recipients: Recipient[];
-    expireTime: number;
-    contractSequenceId: number;
-    sequenceId: number;
-    txHex?: never;
-  };
-}
-
-export interface FullySignedTransaction {
-  txHex: string;
-}
-
 export type SignedTransaction = HalfSignedTransaction | FullySignedTransaction;
 
 interface PrecreateBitGoOptions {

modules/sdk-coin-xrp/package.json

@@ -41,9 +41,11 @@
     ]
   },
   "dependencies": {
+    "@bitgo/abstract-eth": "^1.0.0",
     "@bitgo/sdk-core": "^1.0.1",
+    "@bitgo/statics": "^6.17.0",
     "@bitgo/utxo-lib": "^2.2.2",
-    "bignumber.js": "^8.0.1",
+    "bignumber.js": "^9.0.0",
     "bip32": "^2.0.6",
     "lodash": "^4.17.14",
     "ripple-address-codec": "~4.1.3",

modules/sdk-core/src/bitgo/baseCoin/iBaseCoin.ts

@@ -262,6 +262,16 @@ export interface HalfSignedAccountTransaction {
   };
 }
 
+export interface HalfSignedTransaction extends HalfSignedAccountTransaction {
+  halfSigned: {
+    recipients: Recipient[];
+    expireTime: number;
+    contractSequenceId: number;
+    sequenceId: number;
+    txHex?: never;
+  };
+}
+
 export interface SignedTransactionRequest {
   txRequestId: string;
 }

modules/bitgo/src/v2/coins/fiateur.ts → modules/sdk-core/src/coins/fiateur.ts

@@ -12,7 +12,7 @@ import {
   SignTransactionOptions,
   VerifyAddressOptions,
   VerifyTransactionOptions,
-} from '@bitgo/sdk-core';
+} from '../';
 
 export class FiatEur extends BaseCoin {
   static createInstance(bitgo: BitGoBase): BaseCoin {

modules/bitgo/src/v2/coins/fiatgbp.ts → modules/sdk-core/src/coins/fiatgbp.ts

@@ -12,7 +12,7 @@ import {
   SignTransactionOptions,
   VerifyAddressOptions,
   VerifyTransactionOptions,
-} from '@bitgo/sdk-core';
+} from '../';
 
 export class FiatGBP extends BaseCoin {
   static createInstance(bitgo: BitGoBase): BaseCoin {

modules/bitgo/src/v2/coins/fiatusd.ts → modules/sdk-core/src/coins/fiatusd.ts

@@ -12,7 +12,7 @@ import {
   SignTransactionOptions,
   VerifyAddressOptions,
   VerifyTransactionOptions,
-} from '@bitgo/sdk-core';
+} from '../';
 
 export class FiatUsd extends BaseCoin {
   static createInstance(bitgo: BitGoBase): BaseCoin {

modules/sdk-core/src/coins/index.ts

@@ -0,0 +1,10 @@
+export * from './fiateur';
+export * from './tfiateur';
+export * from './fiatgbp';
+export * from './tfiatgbp';
+export * from './fiatusd';
+export * from './tfiatusd';
+export * from './ofc';
+export * from './ofcToken';
+export * from './susd';
+export * from './tsusd';

modules/bitgo/src/v2/coins/ofc.ts → modules/sdk-core/src/coins/ofc.ts

@@ -14,7 +14,7 @@ import {
   SignTransactionOptions,
   VerifyAddressOptions,
   VerifyTransactionOptions,
-} from '@bitgo/sdk-core';
+} from '../';
 
 export class Ofc extends BaseCoin {
   static createInstance(bitgo: BitGoBase): BaseCoin {