Skip to content

Fix BIP32 encoding error when private key starts with zeroes. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbelshe merged 1 commit into from
Oct 6, 2014
Merged

Fix BIP32 encoding error when private key starts with zeroes. #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/bitcoin/bip32.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,12 @@ BIP32.prototype.build_extended_private_key = function() {

// Private key
this.extended_private_key.push(0);
this.extended_private_key = this.extended_private_key.concat(this.eckey.priv.toByteArrayUnsigned());
var keyBytes = this.eckey.priv.toByteArrayUnsigned();
// We converted from a BigInteger back to an array. Be careful to pad to 32 bytes for bip32 extended key.
while (keyBytes.length < 32) {
keyBytes.unshift(0);
}
this.extended_private_key = this.extended_private_key.concat(keyBytes);
}

BIP32.prototype.extended_private_key_string = function(format) {
Expand Down
33 changes: 33 additions & 0 deletions test/bitcoin/bip32.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,4 +192,37 @@ describe('BIP32', function() {
Bitcoin.setNetwork('testnet');
});

it("initFromSeed reconstruction", function () {
var seeds = [
'd2c282451514b98ae77d479472287336be45d00a55617d65296f4695d7e11251',
'33646e512afdd33e66ee5c5809227698cfaf83a90654baf13c6f3b8e3cba1b7b',
'db7ab7e74208ba688de7fea5e82b578dcf14a1ea5e66373d8799743511442626',
'03e09ff37b11cd310019e730b669916fbc94ba8df3741128195d66ae3b3f8460'
];

seeds.forEach(function(seed) {
var key = new Bitcoin.BIP32().initFromSeed(seed);
var xpub = key.extended_public_key_string();
var xprv = key.extended_private_key_string();

var fromPrivate = new Bitcoin.BIP32(key.extended_private_key_string());
assert.equal(fromPrivate.extended_public_key_string(), xpub, "xpub ok");
assert.equal(fromPrivate.extended_private_key_string(), xprv, "xprv ok");

var fromPublic = new Bitcoin.BIP32(key.extended_public_key_string());
assert.equal(fromPublic.extended_public_key_string(), xpub, "xpub ok from xpub");

var derivedKey = key.derive('m/100');
xpub = derivedKey.extended_public_key_string();
xprv = derivedKey.extended_private_key_string();

var fromPrivate = new Bitcoin.BIP32(derivedKey.extended_private_key_string());
assert.equal(fromPrivate.extended_public_key_string(), xpub, "derived xpub ok");
assert.equal(fromPrivate.extended_private_key_string(), xprv, "derived xprv ok");

var fromPublic = new Bitcoin.BIP32(derivedKey.extended_public_key_string());
assert.equal(fromPublic.extended_public_key_string(), xpub, "derived xpub from xpub ok");
});
});

});