fix: fix config for ofc erc20 tokens #7795
Merged
+495
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArunBala-Bitgo
force-pushed
the
WIN-8435
branch
from
ed94df5 to
ec337d9
Compare
ArunBala-Bitgo
force-pushed
the
WIN-8435
branch
from
ec337d9 to
4969a36
Compare
ArunBala-Bitgo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WIN-8435
We should pass the correct address coin for ofc erc20 tokens
Previously for all ofcerc20 tokens the default value
ethwas picked and usedexport function ofcerc20(
id: string,
name: string,
fullName: string,
decimalPlaces: number,
asset: UnderlyingAsset,
kind: CoinKind = CoinKind.CRYPTO,
features: CoinFeature[] = OfcCoin.DEFAULT_FEATURES,
prefix = '',
suffix: string = name.replace(/^ofc/, '').toUpperCase(),
network: OfcNetwork = Networks.main.ofc,
isToken = true,
addressCoin = 'eth', <--- HERE WE ARE USING DEFAULT VALUE AS ETH
primaryKeyCurve: KeyCurve = KeyCurve.Secp256k1
)