Skip to content

[Testnet] Variable framerate sampling#122

Merged
aliang322 merged 4 commits intotestnetfrom
variable-framerate-sampling
Dec 4, 2024
Merged

[Testnet] Variable framerate sampling#122
aliang322 merged 4 commits intotestnetfrom
variable-framerate-sampling

Conversation

@dylanuys
Copy link
Contributor

@dylanuys dylanuys commented Dec 4, 2024

  • Switching mjpeg codec for png to start with as much quality as possible, and allow jpeg compression to be potentially added later as a random augmentation
  • Sampling by # of frames with a configurable min_fps and max_fps

aliang322
aliang322 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@aliang322 aliang322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Suggestion: Break sample() into smaller functions for readability.

@aliang322 aliang322 merged commit 3add4a8 into testnet Dec 4, 2024
@dylanuys dylanuys deleted the variable-framerate-sampling branch January 6, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aliang322 aliang322 aliang322 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dylanuys @aliang322