Retrofit response body mapper fix #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorich
requested changes
Apr 14, 2025
| @@ -86,14 +86,16 @@ private String parseBody(Response response) throws IOException { | |||
|
|
|||
| if (contentLength != 0L) { | |||
Jorich
requested changes
Apr 14, 2025
Contributor
Jorich
left a comment
Jorich
left a comment
There was a problem hiding this comment.
Väike täiendus veel teha.
| ); | ||
| } | ||
| var bodyString = buffer.clone().readString(charset); | ||
| var bodyStringLength = bodyString.length(); |
Contributor
There was a problem hiding this comment.
Siin on eeldus et bodyString ei ole null, ma ei tea kas ta saab või ei saa seda olla. turvalisem oleks kirjutada
var bodyStringLength = bodyString != null ? bodyString.length() : 0;
Jorich
requested changes
Apr 14, 2025
Contributor
Jorich
left a comment
Jorich
left a comment
There was a problem hiding this comment.
Lisasin ühe kommentaari null safety kohta
Jorich
approved these changes
Apr 15, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.