Skip to content

Comments

[BUG] Fix fit_bootstrap appending empty lists#2

Merged
ulupo merged 1 commit intoBitbol-Lab:mainfrom
ulupo:fix_empty_list_append_bootstrap
May 14, 2024
Merged

[BUG] Fix fit_bootstrap appending empty lists#2
ulupo merged 1 commit intoBitbol-Lab:mainfrom
ulupo:fix_empty_list_append_bootstrap

Conversation

@ulupo
Copy link
Collaborator

@ulupo ulupo commented May 14, 2024

Fixes #1

  • Multiply by a boolean to add nothing instead of an empty slice
  • Use dataclass.replace to properly replace fields in reshape step

- Multiply by a boolean to add nothing instead of an empty slice
- Use dataclass.replace to properly replace fields in reshape step
@ulupo ulupo changed the title Fix #1 Fix fit_bootstrap appending empty lists May 14, 2024
@ulupo ulupo merged commit dcab707 into Bitbol-Lab:main May 14, 2024
@ulupo ulupo changed the title Fix fit_bootstrap appending empty lists [BUG] Fix fit_bootstrap appending empty lists May 14, 2024
@ulupo ulupo deleted the fix_empty_list_append_bootstrap branch May 14, 2024 10:10
@ulupo ulupo added the bug Something isn't working label May 15, 2024
@ulupo ulupo added this to the 0.1.1 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] fit_bootstrap appends empty list

1 participant