Settings that are overridden

[jarolrod]

Settings can be overridden either by passing command line options or by being defined in a bitcoin.conf. If it is overridden, then the value for the setting that is in settings.json will be ignored.

This is the warning that the qt widgets gui gives in such a case:

How should we handle such a case? I think we could just disable the icon and include a description within the setting row that this setting is overridden

[GBKS]

Something like this? These are two options, with the right option being more explicit.

[yashrajd]

If a setting is overridden from CLI or conf file, can we just update the UI to display the right information?

Greying out the setting & icon etc. makes sense, add the help text inside the box saying "This setting has been set from the command line/.conf file"

[yashrajd]

The options that do not have a UI item can be listed in the way Qt app does it currently, possibly in the Developer Options section...

[GBKS]

The greying out works. Very subtle, but should work. I'd only grey out the actual value itself, not the item text on left.

[yashrajd]

I'd like to work on this, please assign it to me.

[yashrajd]

@jarolrod is it possible to identify and show where the setting is getting overridden from? It'd be great to not just show that a setting is being overridden but let users potentially action it.

edit: also need to confirm that we can display the actual overriding value in the UI?

[yashrajd]

[GBKS]

Thanks for creating those mock-ups. I find the language too technical. Let's try to avoid terms like CLI and .conf. It's also not clear what they mean. Do the tags indicate that you can override the setting that's in the conf file? Or is it the other way around?

Maybe just disable those options, add a small info circle, and repeat that the bottom of the screen with a message like "These options are defined in your settings can file and cannot be changed here."?

[ryanofsky]

As of bitcoin-core/gui#602 in bitcoin-qt, GUI settings that have been changed override settings in the bitcoin.conf file. The bitcoin.conf file just provides default settings values that can be customized in the GUI.

CLI settings still override GUI settings so they can be used for debugging and testing. CLI settings should be temporary and probably non-technical users should never encounter them. It seems fine to disable settings in the GUI that are overridden by the command line. Also fine to allow them to be set but note that they won't have an effect until bitcoin is restarted.