Add layout logic diagrams for the block clock#89
Merged
Conversation
Defines and visualizes the logic of how the block clock adjusts to varying screen sizes.
Contributor
|
This looks great, can especially see it being very useful developers as well as future contributors. Also ensures the quality of the blockclock among various devices. When reading the content, it came through that the info for the various sizes were in 4 bigger buckets. An idea could be to state those more intentionally which might help with readers who are trying to pull the information fast. Not a must as the content is 100% understandable as is. The buckets that came through from reading: Default
Showcase mode
Smaller sizes (height < 400)
Even smaller
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines and visualizes the logic of how the block clock adjusts to varying screen sizes. Feedback appreciated.
This came up in conversations in this PR.