Updated Lightning service provider page#809
Conversation
|
Very hard to review when you rename things, as then the diffs show like everything is new, which will slow down things a bit. I suggest we split the rename + changes into two PR's for easier reviewing next time, nevertheless, I'm happy to dive deep into this one and review it as it is. |
|
It's pretty much a whole new page so the whole thing needs a review |
|
Alright Sir, in that case I'm on it 🔎 |
pavlenex
left a comment
There was a problem hiding this comment.
A few nits, but overall this content has come a long way. Graphics are fantastic addition in explaining the concept, and I think you did great job simplifying very complex and abstract concepts, great job Bosch!
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
pavlenex
left a comment
There was a problem hiding this comment.
There's an img conflict that needs to be resolved, but otherwise the page looks good to me.
sbddesign
left a comment
There was a problem hiding this comment.
Looking very nice! I left lots of grammar and style edits.
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
|
Thanks a bunch @sbddesign and @pavlenex , loads of great suggestions. Fixing up some of the bigger changes in my local copy today and will push them for a final update. |
|
Feedback has been addressed |
|
@Bosch-0 Thanks for updating, I found a couple of other grammar issues and noted them above. |
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Closes #744
Made a bunch of updates to this page:
As this page is quite long now with the graphics, we could have two pages, one for LSPs and one for LWSs - thoughts?
💻 Live preview