Skip to content

Updated Lightning service provider page#809

Merged
Bosch-0 merged 30 commits intoBitcoinDesign:masterfrom
Bosch-0:LSP_updates
May 18, 2022
Merged

Updated Lightning service provider page#809
Bosch-0 merged 30 commits intoBitcoinDesign:masterfrom
Bosch-0:LSP_updates

Conversation

@Bosch-0
Copy link
Copy Markdown
Collaborator

@Bosch-0 Bosch-0 commented May 10, 2022

Closes #744

Made a bunch of updates to this page:

  • Changed name of page from Lightning service providers to Lightning services at it covers both LSPS and Lightning Wallet Servers (LWS).
  • Made the page more graphically taking heavily from the liquidity page as there is some similar concepts (LSPs open channels + provide inbound liquidity).
  • Made it more readable - removed a lot of technical jargon that probably isn't necessary to explain the concept.

As this page is quite long now with the graphics, we could have two pages, one for LSPs and one for LWSs - thoughts?

💻 Live preview

@Bosch-0 Bosch-0 requested review from GBKS, pavlenex and sbddesign May 10, 2022 06:11
@pavlenex
Copy link
Copy Markdown
Contributor

Very hard to review when you rename things, as then the diffs show like everything is new, which will slow down things a bit. I suggest we split the rename + changes into two PR's for easier reviewing next time, nevertheless, I'm happy to dive deep into this one and review it as it is.

@Bosch-0
Copy link
Copy Markdown
Collaborator Author

Bosch-0 commented May 10, 2022

It's pretty much a whole new page so the whole thing needs a review

@pavlenex
Copy link
Copy Markdown
Contributor

Alright Sir, in that case I'm on it 🔎

Copy link
Copy Markdown
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, but overall this content has come a long way. Graphics are fantastic addition in explaining the concept, and I think you did great job simplifying very complex and abstract concepts, great job Bosch!

Bosch-0 and others added 2 commits May 10, 2022 19:54
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
@GBKS GBKS added Copy Task is about improving text. Design Task is about designing something. How it works Referring to the How it works section. labels May 11, 2022
pavlenex
pavlenex previously approved these changes May 12, 2022
Copy link
Copy Markdown
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an img conflict that needs to be resolved, but otherwise the page looks good to me.

Copy link
Copy Markdown
Collaborator

@sbddesign sbddesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very nice! I left lots of grammar and style edits.

Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Bosch-0 and others added 11 commits May 13, 2022 10:58
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Bosch-0 and others added 9 commits May 13, 2022 11:05
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
@Bosch-0
Copy link
Copy Markdown
Collaborator Author

Bosch-0 commented May 13, 2022

Thanks a bunch @sbddesign and @pavlenex , loads of great suggestions. Fixing up some of the bigger changes in my local copy today and will push them for a final update.

@Bosch-0
Copy link
Copy Markdown
Collaborator Author

Bosch-0 commented May 16, 2022

Feedback has been addressed

@Bosch-0 Bosch-0 requested review from GBKS, pavlenex and sbddesign May 16, 2022 04:22
@sbddesign
Copy link
Copy Markdown
Collaborator

@Bosch-0 Thanks for updating, I found a couple of other grammar issues and noted them above.

@Bosch-0 Bosch-0 requested a review from sbddesign May 17, 2022 02:58
Copy link
Copy Markdown
Collaborator

@sbddesign sbddesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Bosch-0 Bosch-0 merged commit 19b1675 into BitcoinDesign:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text. Design Task is about designing something. How it works Referring to the How it works section.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow up updates to the Lightning service providers page

4 participants