Merged
Conversation
sbddesign
added
the
Daily spending wallet
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pavlenex
previously approved these changes
Dec 20, 2022
Contributor
pavlenex
left a comment
pavlenex
left a comment
There was a problem hiding this comment.
I think this looks good, though I'm not really nit picky when it comes to visuals.
GBKS
approved these changes
Dec 21, 2022
Contributor
GBKS
left a comment
GBKS
left a comment
There was a problem hiding this comment.
Great addition. Only thing I'd maybe add is a short line of text to explain what the descriptor is. The template explains the other fields, but not the descriptor, despite it being the most complex and alien-looking piece of information here.
I pushed a small layout fix to prevent the last line of text breaking underneath the template image. The fix moves the image in the right column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the manual backup page in the Daily Spending Wallet to display an output descriptor QR code. The use-case: if the user needs to recover in a manual scenario (not as ideal as the nifty cloud backup), then things like derivation path, fingerprint, etc. can be gleaned by simply scanning rather than typing in.
Closes #897
💻 Deploy Preview