Moved config directory and now receiving duplicates

[sigmike]

Hello,

A few weeks ago I moved my .config/PyBitmessage to another computer, ran bitmessage from there for a few days and moved it back to its original place. Everything works fine except since then I receive many messages I've already received.

I think I only receive duplicates of messages that first arrived before I made this config switch, but I'm not sure.

It's different from #611 because the duplicates are still there after I restart bitmesssage.

I'm running current master.

[Atheros1]

You have received the duplicates on the same computer? (As opposed to receiving the same message on two different computers?)

If the sender resends the message then this can happen with the current code. The current code no longer removes duplicates based on the [sender, receiver, subject, message] combination but rather using a hash of the signature (so it is basically a random ID). If the sender resends a message before the previous message expires for some reason, or if you change your client to not send acknowledgements, then you can receive duplicates. I'm not really sure why this would happen with an unmodified client.

[sigmike]

You have received the duplicates on the same computer?

Yes. I received some of them 3 or 4 times.

The current code no longer removes duplicates based on the [sender, receiver, subject, message] combination but rather using a hash of the signature (so it is basically a random ID).

I guess it's the sighash in the inbox table. The duplicate messages do have different sighash. Actually, one of them has an empty sighash. Is that normal? (It's only on one case though. There are duplicates that all have a non blank sighash)

If the sender resends a message before the previous message expires for some reason, or if you change your client to not send acknowledgements, then you can receive duplicates. I'm not really sure why this would happen with an unmodified client.

So these duplicates could mean the sender didn't receive my acknowledgments for some reason?

[Atheros1]

Yes, it could mean that the sender did not receive the acknowledgements.

The empty sighash could be a message that you received before you upgraded your software.

[sigmike]

I got the confirmation the other end is using a standard PyBitMessage and has some messages that haven't received the acknowledgment. I keep receiving duplicates, including on very recent messages. I also received one duplicate from someone else, so I guess it's not a problem with the other end. Is it possible my acknowledgments are invalid somehow? How can I check that?

[PeterSurda]

@sigmike I will try to reproduce it. Are you available for helping me debug it?

[sigmike]

Yes. The issue still occurs.

[PeterSurda]

Based on the config file location, it looks like you're using a Unix-like system other than OSX (probably linux), correct?

[sigmike]

Yes, Linux.

[PeterSurda]

Which version are you using: the latest stable (0.4.4), the latest master, or perhaps my fork (https://github.com/mailchuck/PyBitmessage)?

[sigmike]

Master a little before the time I created the issue. I'm at b3afbb4.

[PeterSurda]

@sigmike Also, what version is the other side (the person who says they haven't received the acknowledgement) use? You write they use "standard PyBitMessage", is that 0.4.4 or latest master? The duplication fixes @Atheros1 made were done post-0.4.4, but I always thought that it is the recipient that should upgrade, the sender doesn't have to.

[sigmike]

The other side is using 0.4.4.