Skip to content

⚡ Optimize instruction string building in Canonicalizer#18

Merged
xkilldash9x merged 1 commit intomainfrom
perf/ir-canonicalizer-optimization-4018986549606110049
Feb 4, 2026
Merged

⚡ Optimize instruction string building in Canonicalizer#18
xkilldash9x merged 1 commit intomainfrom
perf/ir-canonicalizer-optimization-4018986549606110049

Conversation

@xkilldash9x
Copy link
Collaborator

💡 What:

  • Added scratch field (strings.Builder) to Canonicalizer struct to reuse buffer across instructions.
  • Refactored processInstruction to use c.scratch instead of a local variable.
  • Replaced fmt.Sprintf with c.scratch.WriteString for high-frequency instructions: BinOp, UnOp, Store, If, Jump, Return.
  • Updated helper functions (writeSelect, writePhi, writeCallCommon) to accept the shared builder.

🎯 Why:

  • Previously, processInstruction allocated a new strings.Builder (and its internal buffer) for every single instruction processed.
  • fmt.Sprintf added overhead for parsing format strings and allocating intermediate strings.
  • This hot path optimization reduces GC pressure and improves analysis speed.

📊 Measured Improvement:
Benchmark: BenchmarkCanonicalizeFunction (added in pkg/analysis/ir/benchmark_test.go)

  • Baseline: 54783 ns/op, 336 allocs/op
  • Optimized: 52388 ns/op, 312 allocs/op
  • Delta: ~4.4% speedup, 24 fewer allocations per op (~7% reduction).

PR created automatically by Jules for task 4018986549606110049 started by @xkilldash9x

Replaced local `strings.Builder` allocation per instruction with a reused `scratch` builder in the `Canonicalizer` struct.
Replaced frequent `fmt.Sprintf` calls with direct `WriteString` calls to avoid formatting overhead.

Benchmark results (KitchenSink):
Time: -4.4% (54783ns -> 52388ns)
Allocs: -7% (336 -> 312)
Bytes: -3% (13285 -> 12854)

Co-authored-by: xkilldash9x <223238109+xkilldash9x@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@xkilldash9x xkilldash9x merged commit a121629 into main Feb 4, 2026
1 of 2 checks passed
@xkilldash9x xkilldash9x deleted the perf/ir-canonicalizer-optimization-4018986549606110049 branch February 4, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant