⚡ Optimize instruction string building in Canonicalizer#18
Conversation
Replaced local `strings.Builder` allocation per instruction with a reused `scratch` builder in the `Canonicalizer` struct. Replaced frequent `fmt.Sprintf` calls with direct `WriteString` calls to avoid formatting overhead. Benchmark results (KitchenSink): Time: -4.4% (54783ns -> 52388ns) Allocs: -7% (336 -> 312) Bytes: -3% (13285 -> 12854) Co-authored-by: xkilldash9x <223238109+xkilldash9x@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
scratchfield (strings.Builder) toCanonicalizerstruct to reuse buffer across instructions.processInstructionto usec.scratchinstead of a local variable.fmt.Sprintfwithc.scratch.WriteStringfor high-frequency instructions:BinOp,UnOp,Store,If,Jump,Return.writeSelect,writePhi,writeCallCommon) to accept the shared builder.🎯 Why:
processInstructionallocated a newstrings.Builder(and its internal buffer) for every single instruction processed.fmt.Sprintfadded overhead for parsing format strings and allocating intermediate strings.📊 Measured Improvement:
Benchmark:
BenchmarkCanonicalizeFunction(added inpkg/analysis/ir/benchmark_test.go)PR created automatically by Jules for task 4018986549606110049 started by @xkilldash9x