feat(gds-psuu): declarative parameter space constraints#115
Merged
rororowyourboat merged 1 commit intodevfrom Mar 5, 2026
Merged
feat(gds-psuu): declarative parameter space constraints#115rororowyourboat merged 1 commit intodevfrom
rororowyourboat merged 1 commit intodevfrom
Conversation
Add Constraint ABC with LinearConstraint and FunctionalConstraint implementations. ParameterSpace now accepts an optional constraints tuple, validates constraint param references at construction time, and filters infeasible points from grid_points(). RandomSearchOptimizer uses rejection sampling with a 1000-retry limit. 22 new tests. Closes #113
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConstraintABC withLinearConstraint(sum of coefficients ≤ bound) andFunctionalConstraint(arbitrary predicate) implementationsParameterSpacegains optionalconstraintstuple with construction-time validation of param name referencesParameterSpace.is_feasible(point)checks all constraints;grid_points()filters infeasible pointsRandomSearchOptimizeruses rejection sampling (1000 retry limit) when constraints are presentGridSearchOptimizerinherits filtering viagrid_points()— no code change neededTest plan
space.pyandrandom.pyconstraints=()default, existing tests unchangedCloses #113